Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analysis scripts for averaging and plotting contours #124

Open
wants to merge 6 commits into
base: analysis
Choose a base branch
from

Conversation

BrendaQiu
Copy link

Adding contour.py to hcpannot/analysis and average_contour.ipynb to work directory.

@BrendaQiu
Copy link
Author

Also adding lmm.py and lmm.ipynb that analyze and visualize LMM results

@noahbenson noahbenson self-requested a review December 10, 2024 17:17
Copy link
Owner

@noahbenson noahbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to submit this a little late; overall the code is good, just needs to be updated in places to use the proc system instead of the cache files, plus some minor tweaks.

hcpannot/analysis/contour.py Outdated Show resolved Hide resolved
hcpannot/analysis/contour.py Outdated Show resolved Hide resolved
hcpannot/analysis/contour.py Outdated Show resolved Hide resolved
hcpannot/analysis/contour.py Outdated Show resolved Hide resolved
hcpannot/analysis/contour.py Outdated Show resolved Hide resolved
hcpannot/analysis/lmm.py Outdated Show resolved Hide resolved
'''

# create a dictionary to store the data
contour_data = defaultdict(lambda: defaultdict(list))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can just be defaultdict(dict) since you don't actually use contour_data[hemi][tag].append(...) anywhere.

hcpannot/analysis/lmm.py Outdated Show resolved Hide resolved
hcpannot/analysis/lmm.py Outdated Show resolved Hide resolved
hcpannot/analysis/contour.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants