[modified] modified app-installer process in plugin-parser and service-db #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yeonykim2
commented
Apr 1, 2024
yeonykim2
commented
- modified app-installer Handle process. - INSTALL, UNINSTALL, UPGRADE.
- delete the installed models, including activated model, by rpk uninstall.
yeonykim2
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
wooksong,
gichan-jang,
anyj0527,
songgot and
niley7464
as code owners
anyj0527
reviewed
Apr 2, 2024
yeonykim2
force-pushed
the
dev/pkg-mgr-parser/modified-installer
branch
2 times, most recently
from
eb84d5c to
cb91e2b
Compare
jaeyun-jung
reviewed
Apr 3, 2024
jaeyun-jung
reviewed
Apr 3, 2024
jaeyun-jung
reviewed
Apr 3, 2024
jaeyun-jung
reviewed
Apr 3, 2024
jaeyun-jung
reviewed
Apr 3, 2024
jaeyun-jung
reviewed
Apr 3, 2024
yeonykim2
force-pushed
the
dev/pkg-mgr-parser/modified-installer
branch
from
cb91e2b to
7260fa0
Compare
jaeyun-jung
reviewed
Apr 4, 2024
jaeyun-jung
reviewed
Apr 4, 2024
In rpk uninstall, The target model will be deteted, even if the model is activated. Add force-delete model in daemon. Signed-off-by: Suyeon Kim <[email protected]>
yeonykim2
force-pushed
the
dev/pkg-mgr-parser/modified-installer
branch
3 times, most recently
from
3220053 to
144344b
Compare
- modified app-installer Handle process. - INSTALL, UNINSTALL, UPGRADE. - delete the installed models, including activated model, by rpk uninstall. Signed-off-by: Suyeon Kim <[email protected]>
yeonykim2
force-pushed
the
dev/pkg-mgr-parser/modified-installer
branch
from
03b6986 to
c5b870f
Compare
jaeyun-jung
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.