Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use figma.tokens.json as basis for theme #111

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Aug 29, 2024

TODO: fix 60 collisions

Token collisions detected (60):

Collision detected at: tilburg.feedback.informative.background-color! Original value: {tilburg.color.blue.100}, New value: {tilburg.color.blue.100}
Collision detected at: tilburg.feedback.informative.background-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.informative.background-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.informative.background-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.informative.border-color! Original value: {tilburg.color.blue.400}, New value: {tilburg.color.blue.400}
Collision detected at: tilburg.feedback.informative.border-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.informative.border-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.informative.border-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.informative.color! Original value: {tilburg.color.blue.400}, New value: {tilburg.color.blue.400}
Collision detected at: tilburg.feedback.informative.color! Original value: color, New value: color
Collision detected at: tilburg.feedback.informative.color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.informative.color! Original value: true, New value: true
Collision detected at: tilburg.feedback.negative.background-color! Original value: {tilburg.color.red.100}, New value: {tilburg.color.red.100}
Collision detected at: tilburg.feedback.negative.background-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.negative.background-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.negative.background-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.negative.border-color! Original value: {tilburg.color.red.300}, New value: {tilburg.color.red.300}
Collision detected at: tilburg.feedback.negative.border-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.negative.border-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.negative.border-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.negative.color! Original value: {tilburg.color.red.300}, New value: {tilburg.color.red.300}
Collision detected at: tilburg.feedback.negative.color! Original value: color, New value: color
Collision detected at: tilburg.feedback.negative.color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.negative.color! Original value: true, New value: true
Collision detected at: tilburg.feedback.positive.background-color! Original value: {tilburg.color.green.100}, New value: {tilburg.color.green.100}
Collision detected at: tilburg.feedback.positive.background-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.positive.background-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.positive.background-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.positive.border-color! Original value: {tilburg.color.green.300}, New value: {tilburg.color.green.300}
Collision detected at: tilburg.feedback.positive.border-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.positive.border-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.positive.border-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.positive.color! Original value: {tilburg.color.green.300}, New value: {tilburg.color.green.300}
Collision detected at: tilburg.feedback.positive.color! Original value: color, New value: color
Collision detected at: tilburg.feedback.positive.color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.positive.color! Original value: true, New value: true
Collision detected at: tilburg.feedback.warning.background-color! Original value: {tilburg.color.orange.100}, New value: {tilburg.color.orange.100}
Collision detected at: tilburg.feedback.warning.background-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.warning.background-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.warning.background-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.warning.border-color! Original value: {tilburg.color.orange.300}, New value: {tilburg.color.orange.300}
Collision detected at: tilburg.feedback.warning.border-color! Original value: color, New value: color
Collision detected at: tilburg.feedback.warning.border-color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.warning.border-color! Original value: true, New value: true
Collision detected at: tilburg.feedback.warning.color! Original value: {tilburg.color.orange.300}, New value: {tilburg.color.orange.300}
Collision detected at: tilburg.feedback.warning.color! Original value: color, New value: color
Collision detected at: tilburg.feedback.warning.color! Original value: src/common/tilburg/form-control.tokens.json, New value: src/common/tilburg/form-control.tokens.json
Collision detected at: tilburg.feedback.warning.color! Original value: true, New value: true
Collision detected at: tilburg.icon.functional.size! Original value: {tilburg.size.icon.md}, New value: {tilburg.size.icon.md}
Collision detected at: tilburg.icon.functional.size! Original value: sizing, New value: sizing
Collision detected at: tilburg.icon.functional.size! Original value: src/common/tilburg/icon.tokens.json, New value: src/common/tilburg/icon.tokens.json
Collision detected at: tilburg.icon.functional.size! Original value: true, New value: true
Collision detected at: tilburg.icon.toptask.size! Original value: {tilburg.size.icon.4xl}, New value: {tilburg.size.icon.4xl}
Collision detected at: tilburg.icon.toptask.size! Original value: sizing, New value: sizing
Collision detected at: tilburg.icon.toptask.size! Original value: src/common/tilburg/icon.tokens.json, New value: src/common/tilburg/icon.tokens.json
Collision detected at: tilburg.icon.toptask.size! Original value: true, New value: true
Collision detected at: tilburg.pointer-target.min-size! Original value: {tilburg.size.md}, New value: {tilburg.size.md}
Collision detected at: tilburg.pointer-target.min-size! Original value: sizing, New value: sizing
Collision detected at: tilburg.pointer-target.min-size! Original value: src/common/tilburg/pointer-target.tokens.json, New value: src/common/tilburg/pointer-target.tokens.json
Collision detected at: tilburg.pointer-target.min-size! Original value: true, New value: true

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tilburg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:45am

@hansregeer
Copy link
Contributor

I have merged the other MR with the style dictionary changes, please sync this branch with latest from main.

@hansregeer
Copy link
Contributor

@Robbert What would you suggest we do with this MR ? merge it and build on top of it, basically address the TODOS in the collisions?

FYI @NickDITP

hansregeer
hansregeer previously approved these changes Sep 9, 2024
@hansregeer
Copy link
Contributor

@Robbert What would you suggest we do with this MR ? merge it and build on top of it, basically address the TODOS in the collisions?

FYI @NickDITP

OK I read the post in slack, will let Nick follow this up

Copy link
Contributor

@NickDITP NickDITP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we will fix the token collisions whilst we work on them (they still get updated often)

@NickDITP NickDITP merged commit 91a1628 into main Nov 27, 2024
8 checks passed
@NickDITP NickDITP deleted the build/extend-figma-tokens branch November 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants