Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Node.js tooling #929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update Node.js tooling #929

wants to merge 1 commit into from

Conversation

matijs
Copy link
Member

@matijs matijs commented Jan 23, 2025

  • Update Node.js in the repo to v22
  • Update pnpm to latest
  • Refactor type annotations from assert to with and update Prettier to latest to deal with this.

Closes #928

@matijs matijs requested review from Robbert and Yolijn January 23, 2025 08:22
@matijs matijs requested a review from a team as a code owner January 23, 2025 08:22
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 10:42am

- Update Node.js in the repo to v22
- Update pnpm to latest
- Refactor type annotations from `assert` to `with` and update Prettier
  to latest to deal with this.
- Fix Prettier formatting issues new since Prettier v3
@matijs matijs force-pushed the chore/node-tooling branch from 01b3457 to bc70ffc Compare January 23, 2025 10:39
Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (09c20c8) to head (bc70ffc).

Files with missing lines Patch % Lines
packages/tokens-lib/src/design-tokens.ts 50.00% 5 Missing ⚠️
...esign-tokens-table-react/src/DesignTokensTable.tsx 83.33% 1 Missing ⚠️
packages/tokens-lib/src/util.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #929   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files          19       19           
  Lines        1363     1363           
  Branches      177      124   -53     
=======================================
  Hits         1223     1223           
- Misses        139      140    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Node.js + tooling
2 participants