chore: rename spacing and sizing tokens to dimension in voorbeeld tokens #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed all 'spacing' and 'sizing' tokens to 'dimension' in the example tokens to align with the W3C DTCG specification, which recommends dimension as the standard token type for size-related values. This change ensures consistency with the specification and improves clarity in the design token definitions without altering functionality.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
=======================================
Coverage 89.50% 89.50%
=======================================
Files 19 19
Lines 1325 1325
Branches 163 159 -4
=======================================
Hits 1186 1186
- Misses 138 139 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
|
Ik ben verder gegaan met de 'oude' manier nadat deze PR is gemaakt. Iets om in de gaten te houden! Misschien moet dit hernoemen van type dus opnieuw. |
jeffreylauwers
added
the
do not merge
Yolijn
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed all 'spacing' and 'sizing' tokens to 'dimension' in the example tokens to align with the W3C DTCG specification, which recommends dimension as the standard token type for size-related values.
This change ensures consistency with the specification and improves clarity in the design token definitions without altering functionality.