Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump pnpm version to v9 #60

Merged
merged 1 commit into from
May 22, 2024
Merged

build: bump pnpm version to v9 #60

merged 1 commit into from
May 22, 2024

Conversation

matijs
Copy link
Member

@matijs matijs commented May 22, 2024

Update package.json:

  • update "engines.pnpm" field to ^9
  • add "packageManager" field for use with "pnpm/action-setup" Update pnpm-lock.yaml
    Remove the "version" input from the "pnpm/action-setup" action because it will use the value from "packageManager" in package.json

@matijs matijs requested review from Robbert and bddjong May 22, 2024 12:32
@matijs matijs force-pushed the build/pnpm-to-v9 branch from 82a9d87 to 82fae0e Compare May 22, 2024 12:45
Robbert
Robbert previously approved these changes May 22, 2024
@Robbert
Copy link
Member

Robbert commented May 22, 2024

@matijs ik snap niet waarom, maar de build faalt op linting

@matijs
Copy link
Member Author

matijs commented May 22, 2024

@matijs ik snap niet waarom, maar de build faalt op linting

Ik ook niet. @wordpress/eslint-plugin bevat eslint-plugin-jest en ik ging er vanuit dat een extend er gewoon voor zorgt dat dat goed gaat maar ik vermoed dat .jsx buiten de boot valt.

Update package.json:
  - update "engines.pnpm" field to ^9
  - add "packageManager" field for use with "pnpm/action-setup"
Update pnpm-lock.yaml
Remove the "version" input from the "pnpm/action-setup" action because
it will use the value from "packageManager" in `package.json`

Remove duplicate "test" job from continuous-integration.yml

Provde `eslint-env` to pass linting
@matijs matijs force-pushed the build/pnpm-to-v9 branch from 82fae0e to a82b1ef Compare May 22, 2024 15:30
@matijs matijs enabled auto-merge (rebase) May 22, 2024 15:41
@matijs matijs requested a review from Robbert May 22, 2024 15:42
@Robbert Robbert merged commit f1f1aef into main May 22, 2024
8 checks passed
@Robbert Robbert deleted the build/pnpm-to-v9 branch May 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants