Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content/add sponsor worldquant #54

Merged
merged 3 commits into from
Mar 9, 2024
Merged

content/add sponsor worldquant #54

merged 3 commits into from
Mar 9, 2024

Conversation

djacu
Copy link
Contributor

@djacu djacu commented Feb 22, 2024 •
edited
Loading

Add WorldQuant as a gold sponsor.

  • Fixed by replacing PNG with SVG. Image proportions are messed up. Probably because this is a png and all the other logos were svg.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 22, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://nixcon.github.io/2024-na.nixcon.org/pr-preview/pr-54/
on branch gh-pages at 2024-02-29 18:04 PST

@djacu djacu requested a review from davidnuon February 22, 2024 17:01
sarcasticadmin
sarcasticadmin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@sarcasticadmin sarcasticadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good to me

Any thoughts on going with the logo that includes their name in the center? idk if we have access to a quality logo but I pulled this from the bottom of their homepage so you can see the difference:
ss-202402221708627856

@djacu
Copy link
Contributor Author

djacu commented Feb 22, 2024

Preview looks good to me

Any thoughts on going with the logo that includes their name in the center? idk if we have access to a quality logo but I pulled this from the bottom of their homepage so you can see the difference: ss-202402221708627856

I had initially tried that logo but it's a PNG and with the way we have the CSS setup, it ruined the proportions.
image

@sarcasticadmin
Copy link
Contributor

I completely missed the second commit 😆

davidnuon
davidnuon reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@davidnuon davidnuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need a 👍 from the powers that be and we can merge

@davidnuon
Copy link
Contributor

image

@djacu djacu merged commit ebb81a5 into main Mar 9, 2024
1 check passed
@djacu djacu deleted the content/add-sponsor-worldquant branch March 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarcasticadmin sarcasticadmin sarcasticadmin approved these changes

@davidnuon davidnuon davidnuon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djacu @sarcasticadmin @davidnuon