-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake: bump to 2024 #274
Open
Atemu
wants to merge
4
commits into
nix-community:master
Choose a base branch
from
Atemu:2024
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
flake: bump to 2024 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh and the update scripts will need to be tested too. |
Our gitRepo hack fell apart:
|
6797eeb
to
ad4d64c
Compare
Okay, took a few attempts but I fixed that. Currently running an update for 22.1. |
0229f6c
to
923ce52
Compare
Our hack for gitRepo relied on fetching from the Nix store but git 2.35 doesn't allow accessing git repos with "dubious" ownership. This little patch just short-circuits the check.
I successfully ran the LOS update script and reproduced the same state as before (against my local mirror). The build also worked fine in a previous iteration but I'll build once again to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It built fine but I'll have to test on a real device.