base: Run the builder in strict mode, too #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the derivation incorrectly "succeeding" when the build has actually failed, for example due to running out of memory.
|
This has been an issue that has certainly annoyed me too. I trust that you tested this by killing the build? |
|
I have tested it, though not in that exact manner. Let me do that now. |
|
Yes, seems to work (fail in the correct manner) as expected. Successful builds still succeed, too. |
|
Confirmed to work with my scenario linked above, where I go OOM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the derivation incorrectly "succeeding" when the build has actually failed, for example due to running out of memory.
One situation where this is relevant is described here. It's unclear why this manifests only with the nixpkgs bump.