nixos: add an allowTrash option
#243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluelinden
changed the title
allowTrash option set to true by default to the NixOS moduleallowTrash option set to true by default
|
Hm, it may be better if this is set to false by default, because it leaves little |
bluelinden
changed the title
allowTrash option set to true by defaultallowTrash option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue about half an hour ago and tried my hand at fixing it. This resolves parts of #147.
Newer versions of glib's trash implementation support an
x-gvfs-trashmount option on bind mounts, that overrides the "internal filesystem" error that some people in #147 have been facing.This error is basically glib refusing to put things into a bind-mounted trash folder. I have added an option to the NixOS module that fixes this error by default, and is opt-out, but I would be fine making it opt-in if that fits the goals of the project better. I've confirmed that this works on my machine, but if people could test it out on theirs that would be great!
Please let me know if I've missed anything - I'm still relatively new to open-source and I am very tired right now :)
Relevant merge requests:
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4155
https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/222
Relevant issues:
#147
https://gitlab.gnome.org/GNOME/glib/-/issues/1885