-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pay-respects: add module #6210
pay-respects: add module #6210
Conversation
Closes #6204 |
I'm still fairly new to nix so if anything needs changing let me know :) I looked over how a few other modules work and put this together. the tests passed using
I manually tested it in ZSH in my own configuration. and used https://github.com/iffse/pay-respects to get the config for fish and nu. |
I'm not sure if @SigmaSquadron has any interest in maintaining this also as they are the ones that added into nixpkgs |
b36e601
to
c33bce6
Compare
i specified `nix log /nix/store/ys249ajvmjwgrvsdlx6iw2n0fbjgchna-pay-respects-0.6.6.drv`
|
@minhtrancccp I'm not entirely sure about building pay-respects via a nix flake, I installed it via the package manager This PR is just to add options to run |
I'd maintain it if NixOS/rfcs#182 is accepted and |
Upstream issue. Looks like their build stopped working at some point. (Nixpkgs updates do take time, but they're usually reliable and well tested.) |
47825c6
to
b32d424
Compare
Thanks for taking the time to do a code review, I've made those changes :D |
Add pay-respects module including shell integration support for bash, zsh, fish and nushell.
b32d424
to
db9a98e
Compare
Thanks! Merged to master now 🙂 |
Description
Add pay-respects module including shell integration support for bash, zsh, fish and nushell
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC