attempt for RealWorldValueMapping rescale support in Wrapper #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this - and sorry to be so slow to get back to you. I messed up my laptop and have had a family reunion, so I've fallen behind. I will try hard to give you some feedback in the next few days. |
|
here is a link to the dicom |
|
Can we put this DICOM into the tests ? Can we release it with an MIT license to release with the code? |
added 4 commits
December 21, 2012 12:00
* master: BF: doctest output not correctly formatted BF: ornt_transform was returning the inverse of the correct orientation. DOC: Fixed typo in axcodes2ornt docstring ENH: Added funtions to transform orientations.
|
yes I do agree with the changes, ok to close. |
|
Thanks - closing in favor of : #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do have dicoms (from ADNI) that don't have RescaleSlope/Intercept but RealWorldValueMappingSequence and the pixel values matters as these are real/imaginary parts of Philips fieldmaps but it depends on the scanner/software.
I modified the Wrapper._scale_data to use this to rescale the data properly but I do not know the exact specification of such value mapping and there seems to also exists an alternative LUT data.
The RealWorldValueMappingSequence can also contains multiple mappings which is not handled here.