ENH: Close figures in test explicitly #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close figures in test explicitly: when the `output_file` argument is
`None` the `plot_carpet` method does not close figures, and thus a
warning is raised if the number of open figures exceeds a given value.
Fixes:
```
nireports/tests/test_reportlets.py::test_carpetplot[linkage-0.7]
/home/runner/work/nireports/nireports/nireports/reportlets/nuisance.py:326:
RuntimeWarning: More than 20 figures have been opened.
Figures created through the pyplot interface (`matplotlib.pyplot.figure`)
are retained until explicitly closed and may consume too much memory.
(To control this warning, see the rcParam `figure.max_open_warning`).
Consider using `matplotlib.pyplot.close()`.
figure, allaxes = plt.subplots(figsize=(19.2, 10))
```
reported for example in:
https://github.com/nipreps/nireports/actions/runs/12681153218/job/35344304375#step:12:351
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 64.78% 65.16% +0.37%
==========================================
Files 23 25 +2
Lines 2644 2899 +255
Branches 367 522 +155
==========================================
+ Hits 1713 1889 +176
- Misses 816 881 +65
- Partials 115 129 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close figures in test explicitly: when the
output_fileargument isNonetheplot_carpetmethod does not close figures, and thus a warning is raised if the number of open figures exceeds a given value.Fixes:
reported for example in:
https://github.com/nipreps/nireports/actions/runs/12681153218/job/35344304375#step:12:351