Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching image display inspector section to declarative UI #1103

Merged

Conversation

KRLango
Copy link
Contributor

@KRLango KRLango commented Jul 19, 2024

Part of #1093

Copy link
Collaborator

@cmeyer cmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok - but I'm wondering whether you could replace the other use of make_display_type_chooser in LinePlotDisplayInspectorSection at the same time? You don't have to fully convert LinePlotDisplayInspectorSection - just that individual item. I didn't look closely - is there a reason not to do that right now?

Also made a few whitespace comments - there should be two blank lines before top level classes and functions.

nion/swift/Inspector.py Outdated Show resolved Hide resolved
nion/swift/Inspector.py Show resolved Hide resolved
@KRLango KRLango force-pushed the 1093-ImageDisplayInspectorSection branch from d58ee61 to dca0dcc Compare July 23, 2024 10:00
@KRLango KRLango force-pushed the 1093-ImageDisplayInspectorSection branch from dca0dcc to 60547b8 Compare July 23, 2024 10:04
@KRLango
Copy link
Contributor Author

KRLango commented Jul 23, 2024

The reason I didn't change the LinePlotDisplayInspectorSection to use the make_display_type_chooser was to keep this PR focused on just the 1 section of the inspector. My plan was to do the LinePlotDisplayInspectorSection after this PR was accepted using that function and clean up the (then unused) old method at that point.

@cmeyer cmeyer merged commit 23b986b into nion-software:master Jul 23, 2024
14 checks passed
@KRLango KRLango deleted the 1093-ImageDisplayInspectorSection branch July 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants