Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump fixed Rust toolchains to 1.82.0 #3222

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

Eligioo
Copy link
Member

@Eligioo Eligioo commented Jan 7, 2025

What's in this pull request?

Fix the CI and update libmdbx. Rust 1.84 is planned to be released on the 9th of Jan meaning that testing 2 versions older than the current Rust stable will uphold.

1.82.0 introduces unsafe extern blocks (RFC3484) which are used by libmdbx 0.5.3

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@Eligioo Eligioo requested a review from jsdanielh January 7, 2025 13:43
@Eligioo Eligioo force-pushed the stefan/ci-bump-rustc-toolchain branch from a11af29 to a84d071 Compare January 7, 2025 13:54
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eligioo
Copy link
Member Author

Eligioo commented Jan 7, 2025

@sisou the npm release action is still fixed to 1.81.0. Can this one also get increased?

@jsdanielh
Copy link
Member

@sisou the npm release action is still fixed to 1.81.0. Can this one also get increased?

I think it is safe to bump it as well. The reason why we had to pin it, was because the combination of rust 1.82.0 and wasm-bindgen 0.2.[94,95] made wasm-opt to fail per this issue.

Now that we are using a newer version of wasm-bindgen, it doesn't fail. I ran it locally and built fine for me.

@Eligioo Eligioo force-pushed the stefan/ci-bump-rustc-toolchain branch from 0b66528 to 235f0d8 Compare January 9, 2025 09:09
@jsdanielh jsdanielh force-pushed the stefan/ci-bump-rustc-toolchain branch from 235f0d8 to 4020fad Compare January 9, 2025 17:59
@jsdanielh jsdanielh merged commit 4020fad into albatross Jan 9, 2025
8 checks passed
@jsdanielh jsdanielh deleted the stefan/ci-bump-rustc-toolchain branch January 9, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants