Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source2il: show proper types in error messages #88

Merged
merged 4 commits into from
Dec 20, 2024
Merged

source2il: show proper types in error messages #88

merged 4 commits into from
Dec 20, 2024

Conversation

zerbina
Copy link
Collaborator

@zerbina zerbina commented Dec 17, 2024

Summary

Use properly rendered types in source language diagnostic messages
instead of showing just the raw name of the type kind enum value.

Details

  • move the type rendering from vmexec into its own module
  • render the full types when formatting error messages in source2il
  • document why rendering for tkError is not implemented

Notes For Reviewers

@zerbina zerbina added the enhancement New feature or request label Dec 17, 2024
@zerbina zerbina requested a review from saem December 17, 2024 18:33
@zerbina zerbina changed the title source2il: render source2il: show proper types in error messages Dec 17, 2024
saem
saem approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, but I see how this was a detour from the main thrust of work

@saem saem merged commit b67a9ca into nim-works:main Dec 20, 2024
5 checks passed
@zerbina zerbina deleted the proper-type-rendering branch December 20, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saem saem saem approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerbina @saem