pass0: fix the pass crashing for CheckedCallAsgn
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not taken into account that the callee isn't always at child index 0 (such as in the case of `CheckedCallAsgn`).
The wrong node was accessed for fetching the destination local.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs that caused to
CheckedCallAsgnto never work, with itspresence always resulting in an assertion triggering.
Details
A test is added for each possible checked call variation (with/without
assignment, indirect/direct). To match the naming scheme of the new
tests, the existing
t03_checked_void_call.testtest is renamed tot03_checked_call.test.Notes For Reviewers