Minor spelling/grammer fixes for the README #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disruptek
requested changes
Mar 16, 2024
| @@ -17,7 +17,7 @@ | |||
| > | |||
| >*"We didn't have a good story about migrating continuations between threads." - Disruptek* | |||
|
|
|||
| Have you ever asked yourself what would a lock-free MPMC queue look like in nim? | |||
| Have you ever asked yourself what would a lock-free MPMC (*multi-producer multi-consumer*) queue looks like in Nim? | |||
There was a problem hiding this comment.
look is the correct grammatical form here, because we're speaking of the singular -- a lock-free ... queue
| @@ -41,7 +41,7 @@ and Portable Concurrent FIFO Queues With Deterministic Memory Reclamation"](pape | |||
|
|
|||
| The algorithm was chosen to help progress the concurrency story of [CPS](https://github.com/nim-works/cps) for which this was bespokingly made. | |||
|
|
|||
| After adapting the algorithm to nim CPS, disruptek adapted the queue for **any ref object** and was instrumental in ironing out the bugs and improving the performance of Loony. | |||
| After adapting the algorithm to Nim CPS, disruptek adapted the queue for **any ref object** and was instrumental in ironing out the bugs and improving the performance of Loony. | |||
There was a problem hiding this comment.
I would sooner remove this; no one really cares.
| @@ -65,7 +65,8 @@ With the 11 bit aligned implementation we have: | |||
|
|
|||
| ORC is not supported (See [Issue #4](https://github.com/shayanhabibi/loony/issues/4)) | |||
|
|
|||
| Spawn (Nims `threadpool` module) is not supported. *It won't ever be; don't use spawn unless you are a masochist in general.* | |||
| Spawn (via Nim's `threadpool` module) is not supported. *It won't ever be; don't use spawn unless you are a masochist in general.* | |||
There was a problem hiding this comment.
I'm not sure why this would be the case; I think it'd make more sense to wait for a bug report so we can understand the problem better, and ensure we have a canary to show when it suddenly starts working.
There was a problem hiding this comment.
I just modified the existing sentence. Should I remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.