-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #39 #42
Closed
Closed
fix #39 #42
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing a type alias should not be used, it's a mess in Nim's C codegen already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I don't see an alternative to it. The type is different on different platforms. It is not just that different platforms are different. Different versions changed the type behind the type alias as well. What I don't like about it is,
sizeof(Uint)
will be the same ascuint
, so usingUint
can't be seen as safe. In combination ofUint
being exported, I see this as a problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Araq I am reviewing my old PR. This PR is necessary as it is in order to fix #39 properly. If you say importing a type alias is a mess, then go fix it. It is not my fault that it is a mess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not my fault you can only see this one particular way to fix the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a different solution that doesn't break compatibility with existing versions of zlib, go ahead and implement the fix. Then when you realized that the import of the type alias is actually the correct way to handle this, you can still come back merge this and clean up the parts in the C codegen that you don't like.
If you however don't plan to fix bugs in zlib anymore and you don't want to be bothered with other peoples pull request because you are too busy implementing new feauturs in Nim, then you can still archive this repository to indicate that it isn't maintained anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I can also simply close this PR as it's untested on Windows, ignores the fact that the existing wrapper doesn't depend on a header file, etc etc...