Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is-fullscreen to list-windows json output #908

Closed
wants to merge 3 commits into from

Conversation

jonathancyu
Copy link
Contributor

No description provided.

@jonathancyu
Copy link
Contributor Author

This is meant to resolve part of #846

@jonathancyu
Copy link
Contributor Author

jonathancyu commented Dec 30, 2024

and for those curious, here's how I used it to create a fullscreen indicator in sketchybar! 😁

@nikitabobko
Copy link
Owner

Merged with the following patch on top:

diff --git a/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift b/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
index 6f445248..d4cea430 100644
--- a/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
+++ b/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
@@ -58,7 +58,6 @@ public extension ListWindowsCmdArgs {
             ? [
                 .interVar("window-id"), .interVar("right-padding"), .literal(" | "),
                 .interVar("app-name"), .interVar("right-padding"), .literal(" | "),
-                .interVar("window-is-fullscreen"), .interVar("right-padding"), .literal(" | "),
                 .interVar("window-title"),
             ]
             : _format
diff --git a/docs/aerospace-list-windows.adoc b/docs/aerospace-list-windows.adoc
index 0504a15d..47e7aeb7 100644
--- a/docs/aerospace-list-windows.adoc
+++ b/docs/aerospace-list-windows.adoc
@@ -78,6 +78,7 @@ The following variables can be used inside `<output-format>`:
 
 %{window-id}:: Number. Window unique ID
 %{window-title}:: String. Window title
+%{window-is-fullscreen}:: Boolean. Is window in fullscreen by `aerospace fullscreen` command
 
 %{app-bundle-id}:: String. Application unique identifier. https://developer.apple.com/documentation/appstoreconnectapi/bundle_ids[Bundle ID]
 %{app-name}:: String. Application name

blueputty01 pushed a commit to blueputty01/AeroSpace that referenced this pull request Jan 12, 2025
@nikitabobko nikitabobko added the pr-accepted Pull Request is accepted label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-accepted Pull Request is accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants