Fix: aerospace thinks that all windows are closed when you close MacB…

…ook lid

The problem with the MacBook lid is not 100% reproducible, it's flaky

A follow up on #445

The change in MacApp.swift is insignificant, it just further reduces the
chance of detecting problematic ax events.

Sources/AppBundle/layout/refresh.swift

@@ -60,10 +60,13 @@ func gcWindows() {
     // When lockscreen is active, all accessibility API becomes unobservable (all attributes become empty, window id
     // becomes nil, etc.) which tricks AeroSpace into thinking that all windows were closed.
     // The worst part is that windows don't becomes unobservable all together but window by window.
-    if NSWorkspace.shared.frontmostApplication?.bundleIdentifier == "com.apple.loginwindow" {
-        return
-    }
-    for window in MacWindow.allWindows where window.axWindow.containingWindowId() == nil {
+    if NSWorkspace.shared.frontmostApplication?.bundleIdentifier == lockScreenAppBundleId { return }
+    let allWindows = MacWindow.allWindows
+    let toKill: [MacWindow] = allWindows.filter { $0.axWindow.containingWindowId() == nil }
+    // If all windows are "unobservable", it's highly propable that loginwindow might be still active and we are still
+    // recovering from unlock
+    if toKill.count == allWindows.count { return }
+    for window in toKill {
         window.garbageCollect()
     }
 }

Sources/AppBundle/tree/MacApp.swift

@@ -17,6 +17,11 @@ final class MacApp: AbstractApp {
     static var allAppsMap: [pid_t: MacApp] = [:]
 
     fileprivate static func get(_ nsApp: NSRunningApplication) -> MacApp? {
+        // Don't perceive any of the lock screen windows as real windows
+        // Otherwise, false positive ax notifications might trigger that lead to gcWindows
+        if nsApp.bundleIdentifier == lockScreenAppBundleId {
+            return nil
+        }
         let pid = nsApp.processIdentifier
         if let existing = allAppsMap[pid] {
             return existing

Sources/AppBundle/util/appBundleUtil.swift

@@ -2,6 +2,7 @@ import AppKit
 import Common
 import Foundation
 
+let lockScreenAppBundleId = "com.apple.loginwindow"
 let AEROSPACE_WINDOW_ID = "AEROSPACE_WINDOW_ID" // env var
 let AEROSPACE_WORKSPACE = "AEROSPACE_WORKSPACE" // env var