Fix bug. unboundStacktrace was not always recorded

nikitabobko · Dec 9, 2024 · 57803b1 · 57803b1
1 parent c61d93b
commit 57803b1
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/Sources/AppBundle/tree/TreeNode.swift b/Sources/AppBundle/tree/TreeNode.swift
@@ -97,6 +97,7 @@ class TreeNode: Equatable {
         let index = _parent._children.remove(element: self) ?? errorT("Can't find child in its parent")
         check(_parent._mruChildren.remove(self))
         self._parent = nil
+        unboundStacktrace = getStringStacktrace()
 
         return BindingData(parent: _parent, adaptiveWeight: adaptiveWeight, index: index)
     }
@@ -114,13 +115,7 @@ class TreeNode: Equatable {
 
     @discardableResult
     func unbindFromParent() -> BindingData {
-        let bindingData = unbindIfBound()
-        if let bindingData {
-            unboundStacktrace = getStringStacktrace()
-            return bindingData
-        } else {
-            error("\(self) is already unbound. The stacktrace where it was unbound:\n\(unboundStacktrace ?? "nil")")
-        }
+        unbindIfBound() ?? errorT("\(self) is already unbound. The stacktrace where it was unbound:\n\(unboundStacktrace ?? "nil")")
     }
 
     static func == (lhs: TreeNode, rhs: TreeNode) -> Bool {