Disable the defmt feature in the BootInSuccessState #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses critical issues in rustBoot related to the improper handling of the integrity and authenticity checks, which allowed compromised firmware to run without proper validation
panic()Function Behavior: Thepanic()function, intended to halt the system if all boot options are exhausted or an emergency update fails, was not triggering due to a condition related to thedefmtfeature. This allowed execution to continue outside of the match statement, leading to BootInSuccessState being executed each time. This has been resolved, ensuring the system halts as expected when a critical failure occurs, preventing compromised firmware from running.Fixes: #79