Don't match any files for ROMs or disks with no hashes.

NEWS.md

@@ -1,3 +1,8 @@
+X.X (Unreleased)
+================
+
+* Don't match any files for ROMs or disks with no hashes.
+
 2.1 (2024-02-23)
 ================
 

regress/CMakeLists.txt

@@ -142,8 +142,6 @@ set(XFAIL_TESTS
   file-no-crc-wrong-name-other-set.zip.test
   rom-from-extra-loose-directory.zip.test
   rom-from-extra-loose-toplevel.zip.test
-  rom-no-data.dir.test
-  rom-no-data.zip.test
   unknown-rename-failed.zip.test
 )
 

regress/rom-no-data-in-game-wrong-name.vtest

@@ -0,0 +1,14 @@
+description test single-rom game with no data at all
+return 0
+arguments -cFv -e extra -D ../mamedb-no-data.db nodata
+file roms/nodata.zip 1-8-ok.zip {}
+file unknown/nodata.zip {} 1-8-ok.zip
+file unknown/.ckmame.db {} <inline.ckmamedb>
+hashes nodata.zip * cheap
+end-of-inline-data
+stdout
+In game nodata:
+game nodata                                  : not a single file found
+file 08.rom        size       8  crc 3656897d: unknown
+move unknown file '08.rom'
+end-of-inline-data

regress/rom-no-data-in-game.vtest

@@ -0,0 +1,11 @@
+description test single-rom game with no data at all
+return 0
+arguments -cFv -e extra -D ../mamedb-no-data.db nodata
+file roms/nodata.zip 1-4-ok.zip
+file roms/.ckmame.db {} <inline.ckmamedb>
+hashes nodata.zip * cheap
+end-of-inline-data
+stdout
+In game nodata:
+game nodata                                  : correct
+end-of-inline-data

regress/rom-no-data.vtest

@@ -2,9 +2,10 @@ description test single-rom game with no data at all
 return 0
 arguments -cFv -e extra -D ../mamedb-no-data.db nodata
 file extra/nodata.zip 1-4-ok.zip
-file roms/.ckmame.db {} <inline.ckmamedb>
+file extra/.ckmame.db {} <inline.ckmamedb>
+hashes nodata.zip * cheap
 end-of-inline-data
 stdout
-In game nosize:
-game nosize                                  : correct
+In game nodata:
+game nodata                                  : not a single file found
 end-of-inline-data

src/check_game_files.cc

@@ -104,7 +104,7 @@ void check_game_files(Game *game, filetype_t filetype, GameArchives *archives, R
             }
         }
 
-        if (rom.where == FILE_INGAME && match->quality == Match::MISSING && rom.hashes.size > 0 && rom.status != Rom::NO_DUMP) {
+        if (rom.where == FILE_INGAME && match->quality == Match::MISSING && rom.hashes.size > 0 && !rom.hashes.empty() && rom.status != Rom::NO_DUMP) {
             /* search for matching file in other games (via db) */
             if (find_in_romset(filetype, detector_id, &rom, nullptr, game->name, "", match) == FIND_EXISTS) {
                 continue;

src/find.cc

@@ -190,6 +190,10 @@ static find_result_t find_in_db(RomDB *rdb, filetype_t filetype, size_t detector
     for (size_t i = 0; (status != FIND_ERROR && status != FIND_EXISTS) && i < locations.size(); i++) {
 	auto &location = locations[i];
 
+        if (location.rom.hashes.empty()) {
+            continue;
+        }
+
         if (location.game_name == skip_game && skip_file.empty()) {
 	    continue;
         }