Skip to content

Commit

Permalink
Fix fixdats with complete-games-only.
Browse files Browse the repository at this point in the history
  • Loading branch information
dillof committed Jan 8, 2025
1 parent a6de6ef commit 2d40cdf
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 1 deletion.
15 changes: 15 additions & 0 deletions regress/fixdat-missing-both.fixdat
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd">
<datafile>
<header>
<name>Fixdat for ckmame test db (1)</name>
<description>Fixdat by ckmame</description>
<version>0000-00-00 00:00:00</version>
<author>automatically generated</author>
</header>
<game name="clone-8">
<description>clone-8</description>
<rom name="04.rom" size="4" crc="d87f7e0c"/>
<rom name="08.rom" size="8" crc="3656897d"/>
</game>
</datafile>
10 changes: 10 additions & 0 deletions regress/fixdat-missing-complete-only.vtest
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
description test all games, one rom missing, create fixdat
features HAVE_LIBXML2
return 0
arguments --no-status-db --complete-games-only -Fvc -D ../mamedb-lost-parent-ok.db --create-fixdat
file "fixdat_ckmame test db (1).dat" {} fixdat-missing-both.fixdat
directory roms <>
stdout
In game clone-8:
game clone-8 : not a single file found
end-of-inline-data
2 changes: 1 addition & 1 deletion src/check_game_files.cc
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ void check_game_files(Game* game, filetype_t filetype, GameArchives* archives, R

if (rom.where == FILE_INGAME && match->quality == Match::MISSING && rom.hashes.size > 0 &&
!rom.hashes.empty() && rom.status != Rom::NO_DUMP) {
if (configuration.complete_games_only) {
if (configuration.complete_games_only && !configuration.create_fixdat) {
match->quality = Match::UNCHECKED;
if (missing_roms) {
continue;
Expand Down

0 comments on commit 2d40cdf

Please sign in to comment.