Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JSON #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for JSON #10

wants to merge 3 commits into from

Conversation

debbbbie
Copy link

@debbbbie debbbbie commented Feb 5, 2015

No description provided.

@nicolasblanco
Copy link
Owner

Hey thanks for your PR !

Do you know if there may be security issues with the fact to accept JSON ?

@iMacTia
Copy link
Collaborator

iMacTia commented Sep 19, 2018

I'm not entirely convinced about this.
If my request contains a JSON, then my whole request body should be of type JSON and Rails would parse that for me automatically (so that would be validated as an Hash).
Having a JSON structure in the params makes me feel like something strange or wrong is going on and that shouldn't really happen...

Do you have a real-world scenario of when this might happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debbbbie @nicolasblanco @iMacTia @oleander