Fix crash on invalid subtype indication. #1082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the fuzzing crashes found by @avelure.
See #1038 (comment).
In
resolve_resolution
we expectrname
to be of kindT_REF
orT_ELEM_RESOLUTION
otherwise an assert triggers. I simply added a check for the kind and prevent callingresolve_resolution
. If this erroreous input is now given, the parser no longer crashes but instead maneuvers completely off the line and everything afterwards may generate lots of other errors. For such a rare and mean input I think its ok though. What do you think?Cheers