Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add html class to fix dark grey background issue #220

Merged
merged 2 commits into from
Jan 21, 2025
Merged

add html class to fix dark grey background issue #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5963f92
add html class to fix dark grey background issue
davidhunter08 Jan 21, 2025
eb804cd
fix typo
davidhunter08 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/_includes/example.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="app-example{%- if mobile == true %} app-example--mobile{% endif -%}">
<div class="app-example">
<span class="app-example__new-window">
<a href="{{ href }}" target="_blank">Open this example <span class="nhsuk-u-visually-hidden">({{ title }})</span> in a new window</a>
</span>
Expand All @@ -23,7 +23,7 @@
{% endif -%}
</div>

<div class="app-tabs{%- if mobile == true %} app-tabs--mobile{% endif -%}" data-module="app-tabs">
<div class="app-tabs" data-module="app-tabs">
<ul class="app-tabs__list" role="tablist">
<li class="app-tabs__list-item" role="presentation"><a class="app-tabs__tab nhsuk-link--no-visited-state" href="#html-default-{{ id }}" role="tab" id="tab_html-default-{{ id }}" aria-controls="html-default-{{ id }}">HTML</a></li>
<li class="app-tabs__list-item" role="presentation"><a class="app-tabs__tab nhsuk-link--no-visited-state" href="#nunjucks-default-{{ id }}" role="tab" id="tab_nunjucks-default-{{ id }}" aria-controls="nunjucks-default-{{ id }}">Nunjucks</a></li>
Expand Down
2 changes: 1 addition & 1 deletion docs/_includes/layouts/base.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{% from "icon/macro.njk" import nhsappIcon %}

<!DOCTYPE html>
<html lang="en">
<html lang="en" {% if htmlClasses %} class="{{ htmlClasses }}"{% endif %}>
<head>
<meta content="IE=edge" http-equiv="X-UA-Compatible">
<meta charset="utf-8">
Expand Down
1 change: 1 addition & 0 deletions docs/_includes/layouts/example-full-page-mobile-not-logged-in.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

{% block skiplink %}{% endblock %}

{% set htmlClasses = "app-html-background-color-grey-5" %}
{% set mainClasses = "nhsuk-main-wrapper--s" %}

{% block header %}
Expand Down
1 change: 1 addition & 0 deletions docs/_includes/layouts/example-full-page-mobile.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

{% block skiplink %}{% endblock %}

{% set htmlClasses = "app-html-background-color-grey-5" %}
{% set containerClasses = "app-width-container" %}
{% set mainClasses = "app-main-wrapper" %}

Expand Down
6 changes: 6 additions & 0 deletions docs/assets/css/_container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@
.app-main-wrapper {
padding: 0 0 130px; // to give correct spacing for sticky footer
}

// App html class
// Removes the dark grey background at the bottom of shorter pages
.app-html-background-color-grey-5 {
background-color: $color_nhsuk-grey-5;
}
Loading