Data Viz - Changed already published pages from REVIEW to FINAL status #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helen326
previously requested changes
Jan 22, 2025
There was a problem hiding this comment.
Hi Isobel, do the following statuses need to be changed to REVIEW, thanks:
- https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-6faf8337e7b5f59632a866a5b18bcda4ad672632b39bb94fdd41d5b307cd9dd9
- https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-80b408d0a3d858145031bcb79cbfd38dd8ee47839478ace84a85c96f88bdf459
- https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-79c4fa542d95d408fff30213be6afc06bbfc33599e799729dd7c99023fa09f9a
|
Hi Helen,
I checked yesterday that you were happy for everything already in the playbook to be changed to final from review and you said yes. Did you want me to change these back to review? (when no status is specified it defaults to final, so I left it out for the top level sections)
The only content change I made was on the Pie and doughnut chart page to say 'no more than 4' instead of 'no more than 5' because that is what was said in the group yesterday, but can change it back to 5 if necessary.
Thanks,
Isobel Thompson
BI Developer
Digital, Data and Technology
Pronouns: she/her/hers and they/them/theirs
[White rectangle logo containing a blue ribbon, with NHS Business Services Authority written in the right upper corner]
Stella House, Goldcrest Way, Newburn Riverside, Newcastle Upon Tyne, NE15 8NY
Please read our email disclaimer online at: http://www.nhsbsa.nhs.uk/email.
To reduce our environmental footprint, please only print when necessary.
…________________________________
From: Helen326 ***@***.***>
Sent: 22 January 2025 18:03
To: nhsbsa/nhsbsa-digital-playbook ***@***.***>
Cc: Isobel Thompson ***@***.***>; Assign ***@***.***>
Subject: Re: [nhsbsa/nhsbsa-digital-playbook] Data Viz - Changed already published pages from REVIEW to FINAL status (PR #399)
@Helen326 requested changes on this pull request.
Hi Isobel, do the following statuses need to be changed to REVIEW, thanks:
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-6faf8337e7b5f59632a866a5b18bcda4ad672632b39bb94fdd41d5b307cd9dd9
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-80b408d0a3d858145031bcb79cbfd38dd8ee47839478ace84a85c96f88bdf459
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-79c4fa542d95d408fff30213be6afc06bbfc33599e799729dd7c99023fa09f9a
—
Reply to this email directly, view it on GitHub<#399 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4WQF5TQWR56H4Y4YOCMSQ32L7MOLAVCNFSM6AAAAABVVQGC26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRXHEZDGMZRGI>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
|
Hi Isobel,
No, final is fine thanks - I had just noticed that there were a few pages out of the list without the status so thought I'd check. No more than 4 is great, thanks!
Many thanks,
Helen
…________________________________
From: isobelthompson ***@***.***>
Sent: Thursday, January 23, 2025 9:36 AM
To: nhsbsa/nhsbsa-digital-playbook ***@***.***>
Cc: Helen O'Donnell ***@***.***>; Mention ***@***.***>
Subject: Re: [nhsbsa/nhsbsa-digital-playbook] Data Viz - Changed already published pages from REVIEW to FINAL status (PR #399)
Hi Helen,
I checked yesterday that you were happy for everything already in the playbook to be changed to final from review and you said yes. Did you want me to change these back to review? (when no status is specified it defaults to final, so I left it out for the top level sections)
The only content change I made was on the Pie and doughnut chart page to say 'no more than 4' instead of 'no more than 5' because that is what was said in the group yesterday, but can change it back to 5 if necessary.
Thanks,
Isobel Thompson
BI Developer
Digital, Data and Technology
Pronouns: she/her/hers and they/them/theirs
[White rectangle logo containing a blue ribbon, with NHS Business Services Authority written in the right upper corner]
Stella House, Goldcrest Way, Newburn Riverside, Newcastle Upon Tyne, NE15 8NY
Please read our email disclaimer online at: http://www.nhsbsa.nhs.uk/email.
To reduce our environmental footprint, please only print when necessary.
________________________________
From: Helen326 ***@***.***>
Sent: 22 January 2025 18:03
To: nhsbsa/nhsbsa-digital-playbook ***@***.***>
Cc: Isobel Thompson ***@***.***>; Assign ***@***.***>
Subject: Re: [nhsbsa/nhsbsa-digital-playbook] Data Viz - Changed already published pages from REVIEW to FINAL status (PR #399)
@Helen326 requested changes on this pull request.
Hi Isobel, do the following statuses need to be changed to REVIEW, thanks:
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-6faf8337e7b5f59632a866a5b18bcda4ad672632b39bb94fdd41d5b307cd9dd9
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-80b408d0a3d858145031bcb79cbfd38dd8ee47839478ace84a85c96f88bdf459
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-79c4fa542d95d408fff30213be6afc06bbfc33599e799729dd7c99023fa09f9a
—
Reply to this email directly, view it on GitHub<#399 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4WQF5TQWR56H4Y4YOCMSQ32L7MOLAVCNFSM6AAAAABVVQGC26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRXHEZDGMZRGI>.
You are receiving this because you were assigned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#399 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI2GACGWHLOKOMQ2Z6FIUMT2MCZYVAVCNFSM6AAAAABVVQGC26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBZGMZDANZXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
[like] Isobel Thompson reacted to your message:
…________________________________
From: Helen326 ***@***.***>
Sent: Thursday, January 23, 2025 9:40:31 AM
To: nhsbsa/nhsbsa-digital-playbook ***@***.***>
Cc: Isobel Thompson ***@***.***>; Assign ***@***.***>
Subject: Re: [nhsbsa/nhsbsa-digital-playbook] Data Viz - Changed already published pages from REVIEW to FINAL status (PR #399)
Hi Isobel,
No, final is fine thanks - I had just noticed that there were a few pages out of the list without the status so thought I'd check. No more than 4 is great, thanks!
Many thanks,
Helen
________________________________
From: isobelthompson ***@***.***>
Sent: Thursday, January 23, 2025 9:36 AM
To: nhsbsa/nhsbsa-digital-playbook ***@***.***>
Cc: Helen O'Donnell ***@***.***>; Mention ***@***.***>
Subject: Re: [nhsbsa/nhsbsa-digital-playbook] Data Viz - Changed already published pages from REVIEW to FINAL status (PR #399)
Hi Helen,
I checked yesterday that you were happy for everything already in the playbook to be changed to final from review and you said yes. Did you want me to change these back to review? (when no status is specified it defaults to final, so I left it out for the top level sections)
The only content change I made was on the Pie and doughnut chart page to say 'no more than 4' instead of 'no more than 5' because that is what was said in the group yesterday, but can change it back to 5 if necessary.
Thanks,
Isobel Thompson
BI Developer
Digital, Data and Technology
Pronouns: she/her/hers and they/them/theirs
[White rectangle logo containing a blue ribbon, with NHS Business Services Authority written in the right upper corner]
Stella House, Goldcrest Way, Newburn Riverside, Newcastle Upon Tyne, NE15 8NY
Please read our email disclaimer online at: http://www.nhsbsa.nhs.uk/email.
To reduce our environmental footprint, please only print when necessary.
________________________________
From: Helen326 ***@***.***>
Sent: 22 January 2025 18:03
To: nhsbsa/nhsbsa-digital-playbook ***@***.***>
Cc: Isobel Thompson ***@***.***>; Assign ***@***.***>
Subject: Re: [nhsbsa/nhsbsa-digital-playbook] Data Viz - Changed already published pages from REVIEW to FINAL status (PR #399)
@Helen326 requested changes on this pull request.
Hi Isobel, do the following statuses need to be changed to REVIEW, thanks:
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-6faf8337e7b5f59632a866a5b18bcda4ad672632b39bb94fdd41d5b307cd9dd9
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-80b408d0a3d858145031bcb79cbfd38dd8ee47839478ace84a85c96f88bdf459
* https://github.com/nhsbsa/nhsbsa-digital-playbook/pull/399/files#diff-79c4fa542d95d408fff30213be6afc06bbfc33599e799729dd7c99023fa09f9a
—
Reply to this email directly, view it on GitHub<#399 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4WQF5TQWR56H4Y4YOCMSQ32L7MOLAVCNFSM6AAAAABVVQGC26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRXHEZDGMZRGI>.
You are receiving this because you were assigned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#399 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI2GACGWHLOKOMQ2Z6FIUMT2MCZYVAVCNFSM6AAAAABVVQGC26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBZGMZDANZXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#399 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4WQF5WRF7EMPWWVNGAJLHD2MC2I7AVCNFSM6AAAAABVVQGC26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBZGMZTAMBXG4>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
isobelthompson
dismissed
Helen326’s stale review
Discussed and no changes necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pages that were merged into main last week have been reviewed and small changes made. These pages have now been changed to FINAL rather than REVIEW status.