-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components) github discussions #240
chore(components) github discussions #240
Conversation
7ad0c23
to
467259d
Compare
@StephenHill-NHSBSA I've added some code to extract the category from the file path and use that in the URL. This should do what you wanted 😄 {{ appGithubDiscussion({
catagory: page.filePathStem | extractCategory("general-playbook-ideas", ['development', 'security', 'testing'], {
technologies: 'development', design: 'UCD', research: 'UCD' }) | safe,
template: "General-Playbook-Ideas.md",
title: "Change to page '" + page.filePathStem + "' ",
linkText: "Suggest a change to this page"
}) }} |
@WORTI3 , I think it may be a bit too fragile to rely on the path. We could add 11ty template directory data files, and use that? This allows us
https://www.11ty.dev/docs/data-template-dir/ e.g.
and in front matter to choose a specific discussion:
|
I think this would also make the component code simpler (not that its used anywhere else). |
@yantantether removed filter in favour of using 11tydata files. |
@WORTI3 Any guidance you can give would be gratefully appreciated! 💪