Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move proto to dedicated dir ; Add agent/conn_header.go proto #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move proto to dedicated dir ; Add agent/conn_header.go proto #196

wants to merge 2 commits into from

Conversation

hjkatz
Copy link

@hjkatz hjkatz commented Dec 19, 2024

Why

  • The agent conn_header is something we want to use in the ngrok-operator. Rather than vendoring the result there we choose to expose the proto in our SDK then consume in the client (ngrok-operator).
  • I thought to move the proto around and group them into proto/

How

  • Move proto to proto/
  • Update scripts/Makefile
  • Add proto/conn_header.go in agent package
  • Rename internal/pb to internal/mw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hjkatz