Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithBindings Mixin #167

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add WithBindings Mixin #167

merged 1 commit into from
Jun 25, 2024

Conversation

Megalonia
Copy link
Contributor

@Megalonia Megalonia commented Jun 20, 2024 •
edited
Loading

Support WithBindings() mixin for all agent endpoint types

Megalonia
Megalonia commented Jun 20, 2024
View reviewed changes
config/bindings.go Outdated Show resolved Hide resolved
@Megalonia Megalonia removed the request for review from jrobsonchase June 20, 2024 16:00
euank
euank approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good to me, though I think the git log would be more readable with the commits squashed down before merging!

@Megalonia Megalonia merged commit 46e6a32 into main Jun 25, 2024
2 checks passed
@Megalonia Megalonia deleted the mo/bindings branch June 25, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euank euank euank approved these changes

@rkolavo rkolavo Awaiting requested review from rkolavo

@nikolay-ngrok nikolay-ngrok Awaiting requested review from nikolay-ngrok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Megalonia @euank