Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngrok: add deprecated aliases for UserAgent filter options #142

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jrobsonchase
Copy link
Contributor

This was a breaking change that snuck through.

Add some aliases that un-break it so that we're good semver citizens.

@jrobsonchase
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

@Abdiramen Abdiramen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrobsonchase jrobsonchase merged commit c3e07ed into main Nov 28, 2023
2 checks passed
@jrobsonchase jrobsonchase deleted the josh/add-deprecated-ua-filter-aliases branch November 28, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants