-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngrok: add WithAppProtocol #141
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Added the tentative user-facing config options, still need agreement on them though as well as documentation of valid values. |
Ready for review. Implements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks straightforward 👍
@jrobsonchase What does the error-logic look like if someone puts an invalid option? For example, if someone used |
The configuration should fail validation and our services should return some sort of "invalid config" error. We could validate locally before sending it off, but I wouldn't. That way, we don't have to keep things synchronized between the sdk and our backend if new protocols are added. Kinda the same deal as with region validation (or lack thereof 😛) |
4825d0d
to
78bff0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1'd now that it's consistent http1
/http2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I agree that local validation is not a great idea. I think as long as the user can identify where there is an issue, that's sufficient. |
Resolves #139
Adds the
ForwardsProto
field to theBind
request, as well asWithAppProtocol
as an HTTP/labeled option to set it when creating a tunnel.