Additional refinements #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronshekey
requested review from
cody-dot-js,
forzalupo and
melanieseltzer
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
forzalupo
approved these changes
Jan 8, 2025
| @@ -35,7 +35,7 @@ AccordionTrigger.displayName = "AccordionTrigger"; | |||
| const AccordionTriggerIcon = ({ className, ...props }: Omit<IconProps, "svg">) => ( | |||
| <Icon | |||
| {...props} | |||
| svg={<CaretDown weight="fill" />} | |||
There was a problem hiding this comment.
I think this treatment is just too thin and disappears in this context (at least). These also need to be updated with the carets as the leftmost item. Also wondering if we should just allow the user to choose which icon weight for these depending on the context.
Could we just remove this part from this PR?
There was a problem hiding this comment.
yeah, the accordion component is getting a makeover soon and there's gonna be multiple variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still more documentation stragglers. Accordion carets as well.