Introduce Changesets 🎉 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
melanieseltzer
force-pushed
the
changesets
branch
from
85cec76 to
109a36b
Compare
melanieseltzer
force-pushed
the
changesets
branch
from
109a36b to
f919311
Compare
melanieseltzer
force-pushed
the
changesets
branch
from
f919311 to
dea1922
Compare
melanieseltzer
requested review from
cody-dot-js,
aaronshekey and
forzalupo
as code owners
melanieseltzer
commented
Jan 24, 2025
Comment on lines
-31
to
-34
| - name: Grab the released version and store it in an env variable | ||
| run: | | ||
| VERSION=$(jq -r '.version' ./packages/mantle/package.json) | ||
| echo "MANTLE_VERSION=$VERSION" >> $GITHUB_ENV |
There was a problem hiding this comment.
We get outputs from the changesets action, so we can remove this step 🙂 https://github.com/changesets/action?tab=readme-ov-file#outputs
melanieseltzer
commented
Jan 24, 2025
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| if: github.repository == 'ngrok-oss/mantle' |
There was a problem hiding this comment.
I think technically we should have this guard, since we're a public repo that could get forked.
melanieseltzer
force-pushed
the
changesets
branch
from
dea1922 to
d7e093f
Compare
cody-dot-js
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Changesets to help us manage versioning/publishing/changelogs.