Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for QuickJS-NG library. #844

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Jan 23, 2025

QuickJS-NG is a fork of QuickJS which is actively developed.

@xeioex xeioex force-pushed the quickjs-ng branch 2 times, most recently from d8d7908 to f0d680a Compare January 23, 2025 02:46
@xeioex xeioex requested a review from VadimZhestikov January 23, 2025 03:12
@xeioex xeioex marked this pull request as ready for review January 23, 2025 03:12
VadimZhestikov
VadimZhestikov previously approved these changes Jan 23, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Without using JS_SetOpaque(), because in QuickJS-NG opaque pointer
cannot be set for internal classes, including ordinary objects.
VadimZhestikov
VadimZhestikov previously approved these changes Jan 24, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex merged commit e257fba into nginx:master Jan 24, 2025
1 check passed
@xeioex xeioex deleted the quickjs-ng branch January 24, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants