Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickJS shared dict. #809

Merged
merged 2 commits into from
Oct 30, 2024
Merged

QuickJS shared dict. #809

merged 2 commits into from
Oct 30, 2024

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Oct 29, 2024

No description provided.

@xeioex xeioex marked this pull request as draft October 29, 2024 06:55
VadimZhestikov
VadimZhestikov previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex marked this pull request as ready for review October 30, 2024 01:04
@xeioex xeioex requested a review from VadimZhestikov October 30, 2024 01:04
VadimZhestikov
VadimZhestikov reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only style issues are found, balance of lock/unlock, and GC related stuff looks good.

@xeioex xeioex requested a review from VadimZhestikov October 30, 2024 23:44
VadimZhestikov
VadimZhestikov approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex merged commit 352c2e5 into nginx:master Oct 30, 2024
1 check passed
@xeioex xeioex deleted the qjs_shared_dict branch October 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimZhestikov VadimZhestikov VadimZhestikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeioex @VadimZhestikov