fix(sys): drop unnecessary flags from vendored build on Linux #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `-fPIC` is not propagated to PCRE2, causing a linker error on Fedora - `-Wp,-D_FORTIFY_SOURCE=2` conflicts with the compiler builtin default value on Ubuntu 24.04 - The remaining flags are also not necessary for testing the modules, and the binary produced by nginx-sys/vendored is not meant to be used in production. Fixes nginx#80
bavshin-f5
force-pushed
the
cleanup-linux-flags
branch
from
89098e8 to
5d4fa31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fPICis not propagated to PCRE2, causing a linker error on Fedora-Wp,-D_FORTIFY_SOURCE=2conflicts with the compiler builtin default value on Ubuntu 24.04Fixes #80