Fix examples that fail to compile #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekobon
force-pushed
the
fix-for-nginx-1.24.0
branch
3 times, most recently
from
8a31955 to
2665c31
Compare
Casts of pointer types are platform specific. This change adds a platform specific type that is coded for x86_64 or aarch64.
dekobon
force-pushed
the
fix-for-nginx-1.24.0
branch
from
2665c31 to
14b61b5
Compare
bavshin-f5
reviewed
Mar 6, 2024
Comment on lines
+66
to
+70
| #[cfg(target_arch = "aarch64")] | ||
| type Ptr = u8; | ||
|
|
||
| #[cfg(target_arch = "x86_64")] | ||
| type Ptr = i8; |
There was a problem hiding this comment.
The right type to use here would be std::ffi::c_char.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR seeks to fix the examples source files that fail to compile on arm64.
Checklist
Before creating a PR, run through this checklist and mark each as complete.