Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #61

Merged
merged 17 commits into from
Mar 5, 2024
Merged

Fix CI failures #61

merged 17 commits into from
Mar 5, 2024

Conversation

dekobon
Copy link
Contributor

@dekobon dekobon commented Mar 4, 2024

Proposed changes

The change is a bundle of commits intended to fix the CI failures on this project. Contained within the PR are the following:

  • It incorporates the PR to update the NGINX signatures by @allan2
  • Upgrades openssl, zlib, and nginx
  • Zlib is now set to version 1.3.1
  • Openssl is now set to 3.2.1
  • Nginx is now set to 1.24.0 (stable version)
  • It changes the location from which zlib and openssl are downloaded to Github ensuring more consistent downloads
  • This change incorporates additional error checks and debugging output
  • Due to a bug in cargofmt, for now we are passing cargo fmt checks even if they fail in CI

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

1.25.4 was signed by Sergey. To build for 1.25.4, his key is required.
@dekobon dekobon force-pushed the fix-ci branch 2 times, most recently from 2627339 to 0c6a227 Compare March 4, 2024 22:22
@dekobon dekobon force-pushed the fix-ci branch 3 times, most recently from f032111 to ee7a22a Compare March 4, 2024 22:58
dekobon added 13 commits March 4, 2024 15:13
This change recursively traverses the .gnupg home
directory contained withing .cache and ensures that
all files are set to their correct permissions.
This changes the download URL for zlib to Github
because downloading directly from the zlib home page
is unreliable.
There is no benefit to writing a concatenated list of
gpg key names to an empty file. Moreover, this causes
failures when there are too many keys because it results
in an excessively long file name.
Remove cache key for nginx on MacOS build.
Build release before running tests for MacOS tests.
GPG keys are now imported in groups by key server.
Only the Ubuntu key server is now used.
This should improve compatibility across gpg versions.
@dekobon dekobon changed the title Fix CI failures due to zlib location and new signing signatures Fix CI failures Mar 5, 2024
@dekobon dekobon merged commit 2a6124e into nginx:master Mar 5, 2024
4 of 5 checks passed
@dekobon dekobon deleted the fix-ci branch March 5, 2024 18:01
@dekobon dekobon mentioned this pull request Mar 5, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants