Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servers improvements #448

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

dylan-way
Copy link
Contributor

Proposed changes

Update UpdateHTTPServers and UpdateStreamServers:

  • No longer make extra GET requests for each PUT and DELETE request.
  • Removes identical duplicate servers.
  • Returns errors for duplicate servers with different parameters.

Adds Content-Type header to NGINX client PATCH requests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@dylan-way dylan-way requested a review from a team as a code owner January 24, 2025 21:31
Copy link

nginx-bot bot commented Jan 24, 2025

Hi @dylan-way! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community Issues or PRs opened by an external contributor label Jan 24, 2025
@github-actions github-actions bot added the tests Pull requests that update tests label Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@dylan-way
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

Update UpdateHTTPServers and UpdateStreamServers:
- No longer make extra GET requests for each PUT and DELETE request.
- Removes identical duplicate servers.
- Returns errors for duplicate servers with different parameters.
@dylan-way dylan-way force-pushed the update-servers-improvements branch from f625289 to 30363d4 Compare January 28, 2025 16:53
@sjberman sjberman merged commit ffec1a5 into nginx:main Jan 28, 2025
14 checks passed
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed tests Pull requests that update tests labels Jan 29, 2025
@pdabelf5 pdabelf5 mentioned this pull request Jan 29, 2025
1 task
@pdabelf5 pdabelf5 added this to the v2.3.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues or PRs opened by an external contributor enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants