Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move png & json files into Static directory #59

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

nginx-aoife
Copy link
Contributor

@nginx-aoife nginx-aoife commented Jan 10, 2025

Proposed changes

Bug caught by Automation as png images were returning a 404.

Issue: Images are not being displayed.
image

Fix: Moving the images into the static directory.

Images displayed locally after being moved
image

PR also updates the location of a json file that was having a similar issue. It has been moved to the ACM static directory.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@nginx-aoife nginx-aoife requested a review from a team as a code owner January 10, 2025 12:31
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/59/

@nginx-aoife nginx-aoife merged commit 3211902 into main Jan 10, 2025
4 of 5 checks passed
@nginx-aoife nginx-aoife deleted the bug-controller-images branch January 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants