Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve duplicate and scrolling note for self-signed certs #57

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Resolve duplicate and scrolling note for self-signed certs #57

merged 1 commit into from
Jan 9, 2025

Conversation

travisamartin
Copy link
Contributor

This PR makes two improvements to the way we show notes about self-signed certificates:

  1. It removes repeated notes to keep things clear and simple.
  2. It fixes a formatting issue that made the note hard to read and caused it to scroll awkwardly.

Before

image
2025-01-09_10-05-21.mp4

After

image

@travisamartin travisamartin requested a review from a team as a code owner January 9, 2025 17:14
ADubhlaoich
ADubhlaoich approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/57/

@travisamartin travisamartin merged commit 3c4736f into main Jan 9, 2025
4 of 5 checks passed
@travisamartin travisamartin deleted the self-signed-certs-note-fix branch January 9, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jcahilltorre Jcahilltorre Jcahilltorre approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@travisamartin @ADubhlaoich @Jcahilltorre