Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Community READMEs (and more), iteration 1 #1

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Aug 28, 2024

Proposed changes

This is the first iteration for a new open source docs repository. Our intent is to move content, code, etc. from our existing internal docs repo.

I started with our template repository for open source, https://github.com/nginxinc/template-repository , and then:

  • Defined differences for documentation based on
    • Current internal docs repository
    • Knowledge of our current / planned processes for working with communities
    • Lessons learned from the fossy.us 2024 conference

Issue: https://github.com/nginxinc/docs/issues/1029

Checklist

Since this is the first PR for this repository, we need to create a new checklist. If we accept the "README"-type files (including other names) that I've included in this PR, then our new checklist will include more info than we had before.

Unknowns

  • I don't know how to resolve the F5 CLA error
  • I've done my best to set up access parallel to our current docs repo. The screenshot (which I'll delete later) includes my best guesses:

Screenshot 2024-08-28 at 2 26 33 PM

What I did there at least got rid of the errors I had with the CODEOWNERS file

@mjang mjang self-assigned this Aug 28, 2024
@mjang mjang marked this pull request as draft August 28, 2024 21:03
@mjang mjang marked this pull request as ready for review August 28, 2024 21:13
@mjang mjang requested a review from a team August 28, 2024 21:23
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, low LOGAF on my edit suggestions.

The product vs project nomenclature might be slightly confusing: all products are projects, but not all projects are products, as far as dotted lines go.

CHANGELOG.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
GET_STARTED.md Outdated Show resolved Hide resolved
GET_STARTED.md Outdated Show resolved Hide resolved
GET_STARTED.md Outdated Show resolved Hide resolved
PREREQUISITES.md Outdated Show resolved Hide resolved
PREREQUISITES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
SUPPORT.md Outdated Show resolved Hide resolved
SUPPORT.md Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
GET_STARTED.md Outdated Show resolved Hide resolved
GET_STARTED.md Outdated Show resolved Hide resolved
PREREQUISITES.md Outdated Show resolved Hide resolved
PREREQUISITES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mjang
Copy link
Contributor Author

mjang commented Aug 30, 2024

@travisamartin Since I'm at the end of my workday, and you're about to go on PTO for a week, I've added comments on what I'll do on Tuesday. You seem good with the one change that felt uncertain.

Thanks for the review!

- Apply suggestions from @ADubhlaoich, @travismartin, @yar
- Co-authored-by: Alan Dooley <[email protected]>
- Co-authored-by: Travis Martin <[email protected]>
@mjang
Copy link
Contributor Author

mjang commented Sep 3, 2024

@alessfg , I'm having trouble with the CLA build check. I see it works fine in my PR on the template repository: nginx/template-repository#47

I assume I've missed a step. Alessandro, do you know what it is?

(Addressed by @alessfg in a later comment)

@mjang
Copy link
Contributor Author

mjang commented Sep 3, 2024

For the record -- I'm awaiting approvals from @alessfg and @travisamartin , who are both on PTO this week. I've done my best to address comments so far.

@mjang mjang requested a review from jputrino September 4, 2024 20:10
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
GET_STARTED.md Outdated Show resolved Hide resolved
PREREQUISITES.md Outdated Show resolved Hide resolved
@jputrino
Copy link
Contributor

LGTM overall! Only additional suggestion I have is to list in the README which products' docs are in this repo and provide links to the open source repos for the products not represented here.

Copy link
Contributor

@alessfg alessfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment to the docs here, it seems that sometimes markdown is limited to x characters per line (I'm assuming 72-80) and sometimes it is not. My personal preference for markdown is to not limit the characters per line (my code editors default to treating each line as a paragraph), but I am generally okay with either option as long as it is consistent throughout the repo. (Given this repo is mostly going to consist of actual markdown docs it's even more relevant to ensure we are consistent throughout.)

I will also add that I am actually backporting some of the changes made here to the template repo -- great work altogether!

.github/CODEOWNERS Outdated Show resolved Hide resolved
CLA/cla-email-template.pdf Outdated Show resolved Hide resolved
CLA/cla-markdown.md Outdated Show resolved Hide resolved
SUPPORT.md Outdated Show resolved Hide resolved
SUPPORT.md Outdated Show resolved Hide resolved
CONTRIBUTING_GIT.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mjang
Copy link
Contributor Author

mjang commented Oct 11, 2024

As a general comment to the docs here, it seems that sometimes markdown is limited to x characters per line (I'm assuming 72-80)

It's something we haven't applied rigorously to our docs. For the record, markdown linters normally limit lines to 80 characters, solely for readability in some editors.

@mjang
Copy link
Contributor Author

mjang commented Oct 11, 2024

@alessfg , I'm having trouble with the CLA build check. I see it works fine in my PR on the template repository: nginxinc/template-repository#47

I assume I've missed a step. Alessandro, do you know what it is?

As @alessfg told me in #1, we have to check that it works after we make this open.

CONTRIBUTING.md Outdated Show resolved Hide resolved
## Contributing

Please see the [contributing guide](/CONTRIBUTING.md) for guidelines on how to best contribute to this project.

<!-- ## Commercial Support
## Commercial support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Commercial support
## Commercial Support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're now working towards Sentence Case. I realize i should add this info to the style guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! I'm pretty sure the current version of the docs here use a mix of both so it'll probably need a cleanup before going public :)

Copy link
Contributor

@alessfg alessfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple minor typos -- someone should probably do an in depth check before we merge/repo goes public :)

Co-authored-by: Alessandro Fael Garcia <[email protected]>
@mjang
Copy link
Contributor Author

mjang commented Oct 17, 2024

As this repo is a WiP, I'm going to arbitrarily say that I have enough approvals to proceed with merge.

@mjang mjang merged commit 7e3f972 into main Oct 17, 2024
1 check failed
@mjang mjang deleted the readme-updates branch December 11, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants