EXPORT Block Parameters Test #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking EXPORT Block Parameters at Client End Signed-off-by: Girjesh Rajoria <[email protected]>
dang
approved these changes
Dec 5, 2017
nixpanic
suggested changes
May 14, 2018
export-parameters/client.sh
Outdated
| if [ $ret -ne 0 ] | ||
| then | ||
| echo "FAILURE: Write permissions denied" | ||
| exit ret |
There was a problem hiding this comment.
This ret seems wrong, just like in one of the other PRs.
| # enable some more output | ||
| set -x | ||
|
|
||
| [ -n "${SERVER}" ] |
There was a problem hiding this comment.
Without set -e these lines are useless, or add || exit 1.
rakshithakamath94
force-pushed
the
centos-ci
branch
25 times, most recently
from
f0850dc to
a8bd707
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
2 times, most recently
from
801b37d to
c770b94
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
17 times, most recently
from
e9b2ca4 to
a09a2e5
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
7 times, most recently
from
e93af3b to
ade304e
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
from
ade304e to
7be933f
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
3 times, most recently
from
1a86ec1 to
1ed5d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking EXPORT Block Parameters at Client End
Signed-off-by: Girjesh Rajoria [email protected]