Server Reboot test for nfs-ganesha #27
Conversation
Signed-off-by: Girjesh Rajoria <[email protected]>
server-reboot/sever_setup.sh
Outdated
| #Parsing export id from volume export conf file | ||
| export_id=$(grep 'Export_Id' ${conf_file} | sed 's/^[[:space:]]*Export_Id.*=[[:space:]]*\([0-9]*\).*/\1/') | ||
|
|
||
| dbus-send --type=method_call --print-reply --system --dest=org.ganesha.nfsd /org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.UpdateExport string:${conf_file} string:"EXPORT(Export_Id = ${export_id})" |
There was a problem hiding this comment.
We do not recommend UpdateExport to enable/disable ACL. Please move these checks at the beginning itself i.e, in between line:29 and line:30
There was a problem hiding this comment.
This is done as https://github.com/nfs-ganesha/ci-tests/blob/centos-ci/common-scripts/basic-gluster.sh which is used by other ci-tests. Should we change there also?
server-reboot/duffy.py
Outdated
| arch=os.getenv("CENTOS_ARCH") | ||
| count=2 | ||
| server_script=os.getenv("SERVER_TEST_SCRIPT") | ||
| server_setup_script=os.getenv("SERVER_SETUP_SCRIPT") |
There was a problem hiding this comment.
What is the difference between server_script and server_setup_script?
server-reboot/duffy.py
Outdated
| # disable the firewall on server, otherwise the client can not connect | ||
| cmd="""ssh -t -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@%s ' | ||
| curl %s | bash - | ||
| '""" % (b['hosts'][0], server_setup_script) |
There was a problem hiding this comment.
Post reboot, cant we just restart nfs-ganesha process which should take care of exporting the gluster volume too?
|
@soumyakoduri |
| @@ -0,0 +1,110 @@ | |||
| import json, urllib, subprocess, sys, os, time | |||
There was a problem hiding this comment.
I dont think this file should be included, can't you use the common-scripts/basic-gluster-duffy.py instead? If you made modifications, maybe those can be merged into that one?
There was a problem hiding this comment.
modification in these are only required for this particular test. https://github.com/nfs-ganesha/ci-tests/blob/centos-ci/common-scripts/basic-gluster-duffy.py is used by other tests so can not modify it.
| @@ -0,0 +1,209 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Same counts for this one, is it different from common-scripts/basic-gluster.sh?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, all scripts should have a #! for the interpreter (/bin/sh in this case, since they're sh scripts)
server-reboot/server.sh
Outdated
| @@ -1,209 +1,54 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
This line, at least, should stay. Also, some kind of block comment telling what the file does...
rakshithakamath94
force-pushed
the
centos-ci
branch
14 times, most recently
from
245d4b6 to
19df33f
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
2 times, most recently
from
801b37d to
c770b94
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
17 times, most recently
from
e9b2ca4 to
a09a2e5
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
7 times, most recently
from
e93af3b to
ade304e
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
from
ade304e to
7be933f
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
3 times, most recently
from
1a86ec1 to
1ed5d17
Compare
Perform mount from client, start i/o from the client. Reboot the server. Check whether IO got resumed. Test runs on Mount V3, V4.0 and V4.1
Signed-off-by: Girjesh Rajoria [email protected]