Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate.IParamCollection.forAll #88

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Validate.IParamCollection.forAll #88

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bbc013d
Add ErrorMessage for IParam collections
omaus Feb 21, 2024
1250e91
Add `forAll` function to validate IParam collections
omaus Feb 21, 2024
bd4d2de
Add unit test for ErrorMessage (WIP)
omaus Feb 21, 2024
722f808
Add unit test for new ErrorMessage function
omaus Feb 22, 2024
ef46838
Rename function to better match naming design
omaus Mar 7, 2024
51030b3
Update function to call first predicate failing param
omaus Mar 7, 2024
b008d98
Rename function according to naming design
omaus Mar 7, 2024
bc3d4aa
Update XML tags according to renaming
omaus Mar 7, 2024
528155d
Let function failTest all unsatisfying items
omaus Mar 8, 2024
573dd08
Update function to display all failing items at once
omaus Mar 11, 2024
9d46428
Delete missed line
omaus Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ARCExpect/ValidationFunctions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
|> ErrorMessage.ofIParam "is empty."
|> Expecto.Tests.failtestNoStackf "%s"

/// <summary>

Check warning on line 29 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-linux 

This XML comment is invalid: unknown parameter 'expectedValue'

Check warning on line 29 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-linux 

This XML comment is incomplete: no documentation for parameter 'targetValue'

Check warning on line 29 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-windows 

This XML comment is invalid: unknown parameter 'expectedValue'

Check warning on line 29 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-windows 

This XML comment is incomplete: no documentation for parameter 'targetValue'
/// Validates if the value of the given Param is equal to the expected value.
/// </summary>
/// <param name="expectedValue">The expected value to validate against</param>
Expand Down Expand Up @@ -70,7 +70,7 @@
|> ErrorMessage.ofIParam "is invalid."
|> Expecto.Tests.failtestNoStackf "%s"

/// <summary>

Check warning on line 73 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-linux 

This XML comment is invalid: unknown parameter 'pattern'

Check warning on line 73 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-linux 

This XML comment is incomplete: no documentation for parameter 'regex'

Check warning on line 73 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-windows 

This XML comment is invalid: unknown parameter 'pattern'

Check warning on line 73 in src/ARCExpect/ValidationFunctions.fs

View workflow job for this annotation

GitHub Actions / build-and-test-windows 

This XML comment is incomplete: no documentation for parameter 'regex'
/// Validates if the value of the given Param matches a regex.
/// </summary>
/// <param name="pattern">The regex that the value should match</param>
Expand Down Expand Up @@ -165,6 +165,7 @@
if predicate en.Current |> not then
ErrorMessage.ofIParam $"does not satisfy predicate" en.Current
|> Expecto.Tests.failtestNoStackf "%s"
loop ()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested wether this continues after 1 failtestNoStackf is executed? If that throws an exception i am quite sure that it wont

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. It is more complicated to do this than I thought...
But I think I'll get a solution.

else loop ()
| false -> ()
loop ()
Expand Down
Loading