Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subworfklow + schema for references #7412

Merged
merged 12 commits into from
Feb 6, 2025

Conversation

maxulysse
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@pinin4fjords
Copy link
Member

Why is this a subworkflow and not a module?

@maxulysse
Copy link
Member Author

Why is this a subworkflow and not a module?

because it has no process, hence it cannot be a module

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all the warnings, you can merge it in and continue with your testing.

@maxulysse maxulysse enabled auto-merge February 6, 2025 18:33
@maxulysse maxulysse added this pull request to the merge queue Feb 6, 2025
Merged via the queue into nf-core:master with commit c18de39 Feb 6, 2025
14 checks passed
@maxulysse maxulysse deleted the utils_references branch February 6, 2025 18:36
@maxulysse
Copy link
Member Author

Thanks a lot @SPPearce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants