-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial trycycler subsample commit #5654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some relatively minor comments.
Can you remove all the TODO lines too please.
def prefix = task.ext.prefix ?: "${meta.id}" | ||
|
||
""" | ||
count=\$(echo $args | sed -n 's/.*--count\\s*\\([0-9]*\\).*/\\1/p') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment to say what this is actually doing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this code to Nextflow rather than bash, added a comment, in d9cc745
to resolve issue with nf-test and empty gzipped files Co-authored-by: Simon Pearce <[email protected]>
Looks nice :) |
PR checklist
Contributes first trycycler command (trycycler subsample) for #829
Still need to add trycycler cluster, reconcile, msa, partition, and consensus
Includes nf-tests, and a stub, and an nf-test for the stub.
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda